HDDS-15657. excludeContainersDueToFailure resets every iteration, repeatedly failing containers keep being retried - #10892
Open
sravani-revuri wants to merge 1 commit into
Open
Conversation
…eatedly failing containers keep being retried
sravani-revuri
marked this pull request as ready for review
July 29, 2026 07:13
chihsuan
reviewed
Jul 29, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix! @sravani-revuri this makes sense for the ContainerNotFoundException cases, which are the permanently broken containers from the Jira but the other two call sites look transient. Could we confirm that every failure stored here is permanent?
| selectionCriteria = new ContainerBalancerSelectionCriteria(config, | ||
| nodeManager, replicationManager, containerManager, findSourceStrategy, | ||
| containerToSourceMap); | ||
| containerToSourceMap, excludeContainersDueToFailure); |
Contributor
There was a problem hiding this comment.
REPLICATION_NOT_HEALTHY_AFTER_MOVE may be temporary or target-specific. Would it make sense to persist only the ContainerNotFoundException exclusions across iterations, and keep the transient ones iteration-scoped?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
selectionCriteria is re-created fresh every iteration.
If container C failed (ContainerNotFoundException or any other error) in iteration 1 and was added to excludeContainersDueToFailure, it will be tried again in iteration 2 with the same result. This wastes time on permanently broken containers.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15657
How was this patch tested?
Written unit test.