Specify storage inheritance for FILE self-references - #603
Open
alkis wants to merge 6 commits into
Open
Conversation
alkis
changed the title
brkyvz
reviewed
Jul 30, 2026
| | - | set | set | set | external `uri`, `[offset, offset + size)` | | ||
| | - | - | set | - | invalid | | ||
| | - | - | - | set | invalid | | ||
| | - | - | set | set | this file, `[offset, offset + size)` (self-reference) | |
Contributor
There was a problem hiding this comment.
mind updating the spaces for the other lines so that the table is aligned?
Contributor
Author
There was a problem hiding this comment.
Fixed—the table is aligned now. Thanks!
rok
reviewed
Jul 31, 2026
Comment on lines
+773
to
+774
| compressed block or the uncompressed bytes. For a compressed block, the complete range | ||
| is supplied to the codec, and its decompressed output is the resolved value. |
Member
There was a problem hiding this comment.
Should we also store the decompressed size somewhere?
Comment on lines
+319
to
+321
| For a self-reference, `offset` points to the beginning of the 4-byte length and `size` | ||
| is the size of the complete encrypted module, including the length, nonce, ciphertext, | ||
| and GCM tag when present. |
Member
There was a problem hiding this comment.
4-byte length limits us to 2GiB payload. Are we expecting use cases with greater size requirements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specify storage inheritance semantics for
FILEself-references:inlinefield for schemas permitting self-referencesinlinecolumn chunkoffsetandsizeover the stored representationDiscussion: https://lists.apache.org/thread/zrzc7t9fccg92rx3h4fw3ndw3bdo5xr7