GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY#3270
GH-3246: Clarify the behaviour of big decimal for BYTE_ARRAY#3270ArnavBalyan wants to merge 2 commits into
Conversation
ArnavBalyan
commented
Aug 18, 2025
ArnavBalyan
commented
- The behaviour of BYTE_ARRAY or FIXED_LEN_BYTE_ARRAY for big decimals is not clear from the docs.
- Added code comments at the read/writer to make the behaviour more clear for the reader.
- Fixes Is big Decimal in Parquet big endian? #3246
|
cc @shangxinli @wgtmac could you please review thanks! |
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * ValuesReader for variable-length {@code BYTE_ARRAY} columns. |
There was a problem hiding this comment.
I don't think this is the good place to add the comment since this class is for a specific encoding of binary physical type.
As I have replied in the issue, the spec is clear on this so we don't even need the explaination.
There was a problem hiding this comment.
Thanks for the review, yes on retrospect code comment may not be the best, I'll check if the readme can be made more clear since the user pointed to the readme asking for clarity. Will iterate and get back thanks!
|
This pull request has been automatically marked as stale because it has had no activity for at least 2 months. If you are still working on this change or plan to move it forward, please leave a comment or push a new commit so we know to keep it open. Otherwise, this PR will be closed automatically in about one month. Thank you for your contribution to Apache Parquet! |
|
Closing this pull request due to at least 3 months of inactivity. If you would like to continue the work, please feel free to reopen this pull request or open a new one. Thank you for your contribution to Apache Parquet! |
2 participants
