Skip to content

Remove Parquet-Pig#3377

Merged
Fokko merged 5 commits into
apache:masterfrom
dossett:gh-3376
Apr 21, 2026
Merged

Remove Parquet-Pig#3377
Fokko merged 5 commits into
apache:masterfrom
dossett:gh-3376

Conversation

@dossett

@dossett dossett commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

Closes #3376

Removes deprecated parquet-pig functionality

@dossett

dossett commented Dec 29, 2025

Copy link
Copy Markdown
Contributor Author

The maven verify step is failing, but I think that's ok. It's detecting the removal of functionality (i.e. a breaking change), which is the goal.

Fokko
Fokko approved these changes Jan 2, 2026
View reviewed changes

@Fokko Fokko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dossett this looks great!

Comment thread parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftType.java
/**
* @deprecated will be removed in 2.0.0; use StateVisitor instead.
*/
@Deprecated

@Fokko Fokko Jan 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Fokko

Fokko commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

@dossett Can you pull in main once more?

Fokko
Fokko reviewed Jan 13, 2026
View reviewed changes
Comment thread README.md

* Type-specific encoding
* Hive integration (deprecated)
* Pig integration (deprecated)

@Fokko Fokko Jan 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, we leave this in. For example, cascading below has been removed for ages, but is still in the list for historical reasons.

@dossett dossett Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I put that back.

julienledem
julienledem approved these changes Jan 13, 2026
View reviewed changes

@julienledem julienledem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing this old functionality.
(personally observing a minute of silence).

@dossett

dossett commented Jan 13, 2026

Copy link
Copy Markdown
Contributor Author

@dossett Can you pull in main once more?

Rebased and repushed.

@Fokko

Fokko commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

@dossett Can you fix the API issue? I think we can just ignore it

@dossett

dossett commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

@Fokko I think I got it.

@Fokko Fokko mentioned this pull request Mar 10, 2026
Closed
@wgtmac

wgtmac commented Apr 20, 2026

Copy link
Copy Markdown
Member

Could you please resolve the conflict?

@dossett

dossett commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

@wgtmac Fixed, thanks!

@Fokko Fokko changed the title [parquet-thrift] remove pig usage Remove Parquet-Pig Apr 21, 2026
@Fokko Fokko merged commit b8f4dda into apache:master Apr 21, 2026
5 checks passed
@Fokko

Fokko commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

End of an era! Thanks @dossett for cleaning this up, and thanks @julienledem for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@julienledem julienledem julienledem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parquet-thrift should remove usages of parquet-pig and Apache Pig

4 participants

@dossett @Fokko @wgtmac @julienledem