migrated to typed actor in plugin-tester-scala; it will be also used …#699
Closed
kazuf3 wants to merge 2 commits into
Closed
migrated to typed actor in plugin-tester-scala; it will be also used …#699kazuf3 wants to merge 2 commits into
kazuf3 wants to merge 2 commits into
Conversation
…for doc: server/walkthrough/stateful services section
Contributor
Author
|
Do I also have to update build.gradle? |
pjfanning
reviewed
May 17, 2026
Member
pjfanning
left a comment
There was a problem hiding this comment.
can't we keep the legacy actor and create a new sample using the typed actor?
Member
I would suggest leaving https://github.com/apache/pekko-grpc/tree/main/plugin-tester-scala/src/main/scala/example/myapp/helloworld as is and adding a new typedhelloworld package in the same plugin-tester-scala module that uses the typed actor. |
Contributor
Author
|
OK, ill create a new branch/PR with:
|
Contributor
Author
|
Updated PR to #702. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…for doc: server/walkthrough/stateful services section
(See #698)