refactor: remove deprecated HealthCheckSettings constructors (since 1.1.0) - #869
Draft
He-Pin wants to merge 4 commits into
Draft
refactor: remove deprecated HealthCheckSettings constructors (since 1.1.0)#869He-Pin wants to merge 4 commits into
He-Pin wants to merge 4 commits into
Conversation
….1.0) Motivation: The legacy HealthCheckSettings.create and secondary constructor without startupChecks/startupPath parameters were deprecated since 1.1.0. Modification: Remove the deprecated create overload and secondary constructor. Remove the corresponding test case. Result: Cleaner API with only the full constructor available. Tests: Not run - trivial removal of deprecated overloads References: None - deprecated API cleanup
He-Pin
marked this pull request as draft
July 4, 2026 20:33
Motivation: The 5-arg HealthCheckSettings.create() overload was removed, but the Java test creatableThroughLegacyConstructor still called it, causing compilation failures. Modification: Remove the creatableThroughLegacyConstructor test method from HealthCheckTest.java, matching the Scala test removal. Result: Build and Test and Integration test pass (the integration test failure was cascading from the compilation error).
He-Pin
marked this pull request as ready for review
July 5, 2026 04:25
Member
|
I, personally, prefer to keep deprecated methods around for a while and these were only deprecated recently. |
He-Pin
marked this pull request as draft
July 5, 2026 08:40
Member
Author
|
Let's keep it around for the next major release:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The legacy
HealthCheckSettings.createoverload and secondary constructor withoutstartupChecks/startupPathparameters were deprecated since 1.1.0.Modification
Remove the deprecated
createoverload (5-arg version) and deprecated secondary constructor (5-arg version). Remove the corresponding test case for the legacy constructor.Result
Cleaner API with only the full constructor available that includes
startupChecksandstartupPath.Tests
Not run - trivial removal of deprecated overloads
References
None - deprecated API cleanup