Validate EMR_EXTCREATEPEN style entry count before allocation#1117
Open
jmestwa-coder wants to merge 1 commit into
Open
Validate EMR_EXTCREATEPEN style entry count before allocation#1117jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
30dc72e to
efdd43b
Compare
Member
|
duplicate of #1113 I'll also point you to #1113 (comment) I probably won't merge many more changes like this and won't even read them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the
EMR_EXTCREATEPENstyle entry count before allocating the dash pattern array.Changes
HemfPicture.safelyAllocateCheck(numStyleEntries)before allocating the dash pattern array.Why
numStyleEntriesis read from EMF input and directly controls array allocation size.Impact
EMR_EXTCREATEPENwith the recent HEMF allocation-hardening updates.