Skip to content

RANGER-5463: Update userstore version after group-user mapping changes in createOrDeleteXGroupUserList #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kimsehwan96 wants to merge 2 commits into from
Closed

RANGER-5463: Update userstore version after group-user mapping changes in createOrDeleteXGroupUserList #824

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83185e6
RANGER-5463: Update userstore version after group-user mapping change…
kimsehwan96 Jan 27, 2026
c7c35b2
RANGER-5463: Return boolean from createOrDeleteXGroupUsers() to track…
kimsehwan96 Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2964,6 +2964,9 @@ public int createOrDeleteXGroupUserList(List<GroupUserInfo> groupUserInfoList) {

updatedGroups = groupUserInfoList.size();
Copy link
Copy Markdown
Contributor

@mneethiraj mneethiraj Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at implementation of xGroupUserService.createOrDeleteXGroupUsers(), no update might be performed in some scenarios - depending on contents of parameter groupUserInfo. I suggest updating this method to return true when it performs any update and use that to increment updatedGroups.

Copy link
Copy Markdown
Contributor Author

@kimsehwan96 kimsehwan96 Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mneethiraj Changed xGroupUserService.createOrDeleteXGroupUsers() method to return boolean. If the method early returned with no actual updates then return false and If actual update was performed then return true.

And increment updatedGroups and return its count as createOrDeleteGroupUserList return and if at lease one update was really performed then update user store version.

Alos I added test code about it.

Copy link
Copy Markdown
Contributor Author

@kimsehwan96 kimsehwan96 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, returning boolean with name createOrDeleteXGroupUsers might be little awkward

Copy link
Copy Markdown
Contributor Author

@kimsehwan96 kimsehwan96 Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mneethiraj Can you review this? Thanks.

}
if (updatedGroups > 0) {
updateUserStoreVersion("createOrDeleteXGroupUserList(updatedGroups=" + updatedGroups + ")");
}
}

if (logger.isDebugEnabled()) {
Expand Down
Loading