RANGER-4076: Support Java 17 for build and runtime#872
RANGER-4076: Support Java 17 for build and runtime#872pradeepagrawal8184 wants to merge 12 commits intomasterfrom
Conversation
9755de9 to
68df023
Compare
8d5a3ce to
58be178
Compare
58be178 to
fc89780
Compare
|
Thanks @pradeepagrawal8184 for this patch, I think it is best to update the CI/CD build in this PR by removing builds for JDK8 and JDK11 and adding support for JDK17. The jobs |
fc89780 to
4732fb2
Compare
4732fb2 to
9467111
Compare
|
Current ranger master branch shipped jars vs jar shipped with this branch changes. |
e7cd2ea to
9f9247c
Compare
|
Hi @pradeepagrawal8184, |
@ramackri : Spring upgrade can be handled separately. We can discuss that in the spring upgrade ticket after this PR merge and decide. |
kumaab
left a comment
There was a problem hiding this comment.
I've reviewed the changes partially (since this is a big patch), some JWT related functionalities recently added seems to have been removed, please rebase and take a look. thanks.
890fc0a to
32469c3
Compare
32469c3 to
f3b4e48
Compare
f3b4e48 to
2232594
Compare
2232594 to
db9f4d1
Compare
db9f4d1 to
e1c0400
Compare
e1c0400 to
e459ab0
Compare
e459ab0 to
53f814f
Compare
|
@copilot please review this PR |
| private static final String KMS_LIST_API_ENDPOINT = "v1/keys/names"; // GET | ||
| private static final String ERROR_MSG = " You can still save the repository and start creating policies, but you would not be able to use autocomplete for resource names. Check ranger_admin.log for more info."; | ||
| private static final String AUTH_TYPE_KERBEROS = "kerberos"; | ||
| private static final ReentrantLock LOCK = new ReentrantLock(); |
There was a problem hiding this comment.
Is this Lock required? Is it getting used somewhere?
| import com.hortonworks.registries.schemaregistry.client.LoadBalancedFailoverUrlSelector; | ||
| import com.hortonworks.registries.schemaregistry.client.SchemaRegistryClient.Configuration; | ||
| import com.hortonworks.registries.schemaregistry.client.UrlSelector; | ||
| import com.hortonworks.registries.shaded.com.fasterxml.jackson.jaxrs.json.JacksonJaxbJsonProvider; |
There was a problem hiding this comment.
L24-L32: Is the shaded version really required?
What changes were proposed in this pull request?
Support jdk17 build in Ranger. This change shall discontinue build support on jdk8/11
How was this patch tested?
Manual install, start and crud operations on the policy, group, users, service etc.