[Studio] Test Prometheus data source connections - #517
Closed
Aias00 wants to merge 1 commit into
Closed
Conversation
Aias00
force-pushed
the
fix/studio-prometheus-datasource-test
branch
from
July 24, 2026 07:14
5fd5000 to
9f89266
Compare
Author
|
Superseded by #637. Consolidated with related Metrics/Prometheus validation changes to reduce review overhead while preserving the same scoped fixes and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This is a small follow-up for #431. The Settings data source test endpoint still returned a fixed success response, so users could not validate whether a configured Prometheus-compatible source was actually reachable.
Changes
SettingsService.testDataSourcewith a real Prometheus-compatible HTTP API probe./api/v1/query?query=upfor Prometheus, VictoriaMetrics, Thanos, and Mimir style data sources.Non-goals
This PR does not add credential fields or replace dashboard charts. It only makes the existing test endpoint validate the configured Prometheus-compatible URL.
Verification
JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -B -ntp -Dtest=SettingsServiceTest testJAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -B -ntp test