Skip to content

[Studio] Validate instance delete requests - #552

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-instance-delete-validation
Closed

[Studio] Validate instance delete requests#552
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-instance-delete-validation

Conversation

@Aias00

@Aias00 Aias00 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • replace instance delete map parsing with a typed request DTO
  • validate required instance ids before invoking delete operations
  • add controller tests for blank and missing delete ids

Scope

  • RocketMQ Studio contest scope: Track 1 / ARCH-01 instance access management hardening
  • Does not introduce Namespace behavior

Tests

  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=InstanceControllerTest,InstanceServiceTest test
  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test
  • git diff --check

Copilot AI review requested due to automatic review settings July 24, 2026 14:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #634. Folded into the consolidated instance resource action validation PR to keep related instance request validation fixes in one review unit.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants