Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,10 @@ public class ProducerConnectionService {

public List<ProducerConnectionVO> listConnections(String topic, String producerGroup) {
log.info("Listing producer connections, topic={}, producerGroup={}", topic, producerGroup);
String normalizedTopic = normalizeFilter(topic);
String normalizedProducerGroup = normalizeFilter(producerGroup);
return clientService.listConnections(null, ClientType.Producer.name()).stream()
.filter(connection -> matchesFilter(connection, topic, producerGroup))
.filter(connection -> matchesFilter(connection, normalizedTopic, normalizedProducerGroup))
.map(this::toProducerConnection)
.toList();
}
Expand All @@ -60,4 +62,8 @@ private ProducerConnectionVO toProducerConnection(ClientConnectionVO connection)
private boolean hasText(String value) {
return value != null && !value.trim().isEmpty();
}

private String normalizeFilter(String value) {
return hasText(value) ? value.trim() : null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,25 @@ void listConnectionsShouldFallbackToProducerGroupWhenTopicIsMissing() {
assertThat(result.get(0).getClientId()).isEqualTo("producer-1");
}

@Test
void listConnectionsShouldTrimFilterValues() {
ClientConnectionVO producer = ClientConnectionVO.builder()
.clientId("producer-1")
.type(ClientType.Producer)
.groupOrTopic("order-topic")
.producerGroup("pg-order")
.address("10.0.0.1:38888")
.language(ClientLanguage.Java)
.version("5.1.0")
.build();
when(clientService.listConnections(null, ClientType.Producer.name())).thenReturn(List.of(producer));

List<ProducerConnectionVO> result = producerConnectionService.listConnections(" order-topic ", " pg-order ");

assertThat(result).hasSize(1);
assertThat(result.get(0).getClientId()).isEqualTo("producer-1");
}

@Test
void listConnectionsShouldRequireProducerGroupWhenBothFiltersAreProvided() {
ClientConnectionVO producer = ClientConnectionVO.builder()
Expand Down
Loading