Skip to content

[Studio] Validate ACL create inputs - #565

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-acl-create-validation
Closed

[Studio] Validate ACL create inputs#565
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-acl-create-validation

Conversation

@Aias00

@Aias00 Aias00 commented Jul 24, 2026

Copy link
Copy Markdown

Summary

  • reject ACL rule creation when principal or resource is blank
  • reject ACL user creation when username is blank
  • cover invalid create inputs and verify they are not persisted

Validation

  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q -Dtest=AclServiceTest test
  • JAVA_HOME=/Users/aias/Library/Java/JavaVirtualMachines/openjdk-21.0.2/Contents/Home mvn -q test (294 tests, 0 failures, 0 errors)
  • git diff --check

Copilot AI review requested due to automatic review settings July 24, 2026 16:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #636. Consolidated with related ACL request validation changes to reduce review overhead while preserving the same scoped fixes and tests.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants