Skip to content

[Studio] Preserve Topic table pagination - #573

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-topic-pagination-state
Closed

[Studio] Preserve Topic table pagination#573
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-topic-pagination-state

Conversation

@Aias00

@Aias00 Aias00 commented Jul 25, 2026

Copy link
Copy Markdown

Summary

  • control the Topic table pagination state so detail modal updates do not reset the current page
  • reset the Topic table to the first page only when filters change
  • add a regression test for keeping page 2 visible after opening and closing Topic details

Fixes #161.

Validation

  • npm test -- --run src/pages/instance/__tests__/TopicPage.test.tsx
  • npm test (164 tests, 37 files passed)
  • npm run lint (0 errors, 4 existing fast-refresh warnings)
  • npm run build
  • npx tsc -b --pretty false
  • git diff --cached --check

Copilot AI review requested due to automatic review settings July 25, 2026 05:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #638. Folded into the consolidated page data loading/state PR to keep Topic pagination state with related page-level data loading behavior.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants