Skip to content

[Studio] fix: validate alert rule updates - #575

Open
yx9o wants to merge 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-574
Open

[Studio] fix: validate alert rule updates#575
yx9o wants to merge 1 commit into
apache:rocketmq-studiofrom
yx9o:dev-574

Conversation

@yx9o

@yx9o yx9o commented Jul 25, 2026

Copy link
Copy Markdown

What is the purpose of the change

Fixes #574 .

Prevent /api/alert-rules/update from returning an internal server error for missing IDs or creating new rules for blank and unknown IDs.

This complements #549, which validates alert rule toggle and delete request bodies; this change covers update semantics.

Brief changelog

  • Reject null and blank alert rule IDs with HTTP 400.
  • Reject unknown alert rule IDs with HTTP 404.
  • Atomically replace existing rules so update cannot create a missing rule.
  • Add service and repository regression tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant