Skip to content

[Studio] Refresh alert rule threshold unit - #599

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-alert-rule-threshold-unit
Closed

[Studio] Refresh alert rule threshold unit#599
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-alert-rule-threshold-unit

Conversation

@Aias00

@Aias00 Aias00 commented Jul 26, 2026

Copy link
Copy Markdown

Summary

  • derive alert rule thresholdUnit through one shared payload helper
  • refresh thresholdUnit on edit as well as create so changing the metric cannot submit a stale unit
  • add regression coverage for metric-to-unit payload mapping

Verification

  • npm --prefix web test -- --run src/pages/ops/tests/alerts.test.ts
  • (cd web && npm exec eslint -- src/pages/ops/alerts.tsx src/pages/ops/alertRulePayload.ts src/pages/ops/tests/alerts.test.ts)
  • npm --prefix web run build

Copilot AI review requested due to automatic review settings July 26, 2026 00:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #632. Folded into the consolidated ops request validation PR to keep alert request payload handling with the related ops validation changes.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants