Skip to content

[Studio] Scope data source test loading by row - #601

Closed
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-datasource-row-testing
Closed

[Studio] Scope data source test loading by row#601
Aias00 wants to merge 1 commit into
apache:rocketmq-studiofrom
Aias00:fix/studio-datasource-row-testing

Conversation

@Aias00

@Aias00 Aias00 commented Jul 26, 2026

Copy link
Copy Markdown

Summary

  • track data source connection-test loading by row key instead of a global boolean
  • keep modal connection-test loading isolated from table row actions
  • add regression coverage that only the clicked row shows loading

Verification

  • npm --prefix web test -- --run src/pages/settings/tests/DataSourceTab.test.tsx
  • (cd web && npm exec eslint -- src/pages/settings/index.tsx src/pages/settings/tests/DataSourceTab.test.tsx)
  • npm --prefix web run build

Copilot AI review requested due to automatic review settings July 26, 2026 01:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 27, 2026

Copy link
Copy Markdown
Author

Superseded by #643. Consolidated with related data source management changes to reduce review overhead while preserving the same scoped fixes and tests.

@Aias00 Aias00 closed this Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants