Skip to content

[SOLR-18176] HttpShardHandler query throughput bottleneck from ZooKeeper #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlbiscoc merged 6 commits into from
Apr 9, 2026
Merged

[SOLR-18176] HttpShardHandler query throughput bottleneck from ZooKeeper #4237

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c05746
Get collection state from cache
mlbiscoc Mar 24, 2026
b2c817d
Add changelog
mlbiscoc Mar 25, 2026
14483dd
Add test
mlbiscoc Mar 30, 2026
15c7534
Address PR comments
mlbiscoc Apr 1, 2026
bcd9ad8
tidy
mlbiscoc Apr 2, 2026
620f0e2
Changelog change
mlbiscoc Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions solr/core/src/java/org/apache/solr/handler/component/CloudReplicaSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,14 @@ private void withShardsParam(Builder builder, String shardsParam) {
if (sliceOrUrl.indexOf('/') < 0) {
// this is a logical shard
this.slices[i] = sliceOrUrl;
DocCollection coll = clusterState.getCollectionOrNull(builder.collection, true);
if (coll == null) {
throw new SolrException(
SolrException.ErrorCode.BAD_REQUEST,
"Could not find collection to resolve replicas: " + builder.collection);
}
replicas[i] =
findReplicas(
builder,
shardsParam,
clusterState,
clusterState.getCollection(builder.collection).getSlice(sliceOrUrl));
findReplicas(builder, shardsParam, clusterState, coll.getSlice(sliceOrUrl));
} else {
// this has urls
this.replicas[i] = StrUtils.splitSmart(sliceOrUrl, "|", true);
Expand Down Expand Up @@ -189,7 +191,11 @@ private void addSlices(
String collectionName,
String shardKeys,
boolean multiCollection) {
DocCollection coll = state.getCollection(collectionName);
DocCollection coll = state.getCollectionOrNull(collectionName, true);
if (coll == null) {
throw new SolrException(
SolrException.ErrorCode.BAD_REQUEST, "Could not find collection to add slices: " + collectionName);
}
Collection<Slice> slices = coll.getRouter().getSearchSlices(shardKeys, params, coll);
ClientUtils.addSlices(target, collectionName, slices, multiCollection);
}
Expand Down
Loading