SOLR-18180: migrate configset upload tool to using SolrJ Upload #4250
SOLR-18180: migrate configset upload tool to using SolrJ Upload #4250epugh wants to merge 9 commits intoapache:mainfrom
Conversation
…per directly Co-authored-by: epugh <22395+epugh@users.noreply.github.com> Agent-Logs-Url: https://github.com/epugh/solr/sessions/c3891b66-e85f-4a46-afe1-c190c28c69e8
…figset-upload-tool
…t and UpdateACLToolTest Agent-Logs-Url: https://github.com/epugh/solr/sessions/206b9da4-e307-462a-aa43-677fdd7d647e Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
… supported Agent-Logs-Url: https://github.com/epugh/solr/sessions/ff48b389-e8b3-458b-bf66-e7dae8d19dcf Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
|
|
||
| try (var solrClient = CLIUtils.getSolrClient(cli)) { | ||
| byte[] zipData = createZipData(confPath); | ||
| var request = new GenericV2SolrRequest(SolrRequest.METHOD.PUT, "/configsets/" + confName); |
There was a problem hiding this comment.
We have a SolrJ end point to use... Need to dig into our annotations?
…equest in ConfigSetUploadTool Agent-Logs-Url: https://github.com/epugh/solr/sessions/ee6c0d88-0103-424c-9de9-850e5a6fa682 Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
Agent-Logs-Url: https://github.com/epugh/solr/sessions/ee6c0d88-0103-424c-9de9-850e5a6fa682 Co-authored-by: epugh <22395+epugh@users.noreply.github.com>
| @QueryParam("overwrite") Boolean overwrite, | ||
| @QueryParam("cleanup") Boolean cleanup, | ||
| @RequestBody(required = true) InputStream requestBody) | ||
| @RequestBody( |
There was a problem hiding this comment.
@gerlowskija I am curious why copilot thought we needed to modify this end point... In this PR I was hoping to just pick up on using an existing end point... Maybe it wasn't fully fleshed out?
There was a problem hiding this comment.
It IS in our spreadsheet as PUT /api/configsets/configsetName <req-body> in https://docs.google.com/spreadsheets/d/1HAoBBFPpSiT8mJmgNZKkZAPwfCfPvlc08m5jz3fQBpA/edit?gid=687305869#gid=687305869
There was a problem hiding this comment.
the test_zk.bats passed!
There was a problem hiding this comment.
I wanted to balance the ConfigSetUploadToolTest.java testing pattern, so I pulled this out of ZkSubCommandsTest.java.
https://issues.apache.org/jira/browse/SOLR-18180
Description
Instead of a direct Zookeeper interface, lets use the SolrJ Upload endpoint.
Solution
Use our existing Solr api to upload a configSet.
Tests
manual and added new ones.