minor: EmbeddedSolrServer.getDefaultCollection#4252
Open
dsmiley wants to merge 1 commit intoapache:mainfrom
Open
minor: EmbeddedSolrServer.getDefaultCollection#4252dsmiley wants to merge 1 commit intoapache:mainfrom
dsmiley wants to merge 1 commit intoapache:mainfrom
Conversation
It wasn't working as it should.
epugh
approved these changes
Mar 31, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Good find and also just speaks to the weirdness that someday we will sort out.
dsmiley
commented
Mar 31, 2026
Contributor
Author
dsmiley
left a comment
dsmiley
left a comment
There was a problem hiding this comment.
This stems from the fact that SolrClient.defaultCollection was added ~recently. EmbeddedSolrServer didn't get the memo (i.e. didn't change) when it should have been.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't working as it should.