Skip to content

SOLR-13309: Simplify references numeric-range classes#4254

Open
gerlowskija wants to merge 1 commit intoapache:mainfrom
gerlowskija:SOLR-13309-fix-numericrange-field-referencing
Open

SOLR-13309: Simplify references numeric-range classes#4254
gerlowskija wants to merge 1 commit intoapache:mainfrom
gerlowskija:SOLR-13309-fix-numericrange-field-referencing

Conversation

@gerlowskija
Copy link
Copy Markdown
Contributor

Description

Prior to this commit, the org.apache.solr.schema.numericrange subpackage was not in the list of packages that SolrResourceLoader uses to support the "shorthand" class syntax. As a result, references to these classes had to use fully-qualified syntax
('org.apache.solr.schema.numericRange.IntLongField'), or semi-qualified ('solr.numericrange.IntLongField'). This was quite awkward.

Solution

This commit adds the 'numericrange' subpackage to the special list used by SRL, and cleans up the references to these field types to use the preferred shorthand syntax.

No changelog entry is needed for this change since these field types haven't been released yet so there's no "change" here from a user's perspective.

Tests

Additional numeric-range field tests continue to pass. No new tests added.

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Prior to this commit, the org.apache.solr.schema.numericrange subpackage
was not in the list of packages that SolrResourceLoader uses to support
the "shorthand" class syntax.  As a result, references to these classes
had to use fully-qualified syntax
('org.apache.solr.schema.numericRange.IntLongField'), or semi-qualified
('solr.numericrange.IntLongField').  This was quite awkward.

This commit adds the 'numericrange' subpackage to the special list used
by SRL, and cleans up the references to these field types to use the
preferred shorthand syntax.
@github-actions github-actions bot added documentation Improvements or additions to documentation tests cat:schema labels Mar 31, 2026
@gerlowskija
Copy link
Copy Markdown
Contributor Author

Note to self that 'test' and 'check' pass locally for me. Will aim to merge this EOW and then close out SOLR-13309 pending any review feedback.

Copy link
Copy Markdown
Contributor

@HoustonPutman HoustonPutman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cat:schema documentation Improvements or additions to documentation no-changelog tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants