SOLR-13309: Simplify references numeric-range classes#4254
Open
gerlowskija wants to merge 1 commit intoapache:mainfrom
Open
SOLR-13309: Simplify references numeric-range classes#4254gerlowskija wants to merge 1 commit intoapache:mainfrom
gerlowskija wants to merge 1 commit intoapache:mainfrom
Conversation
Prior to this commit, the org.apache.solr.schema.numericrange subpackage
was not in the list of packages that SolrResourceLoader uses to support
the "shorthand" class syntax. As a result, references to these classes
had to use fully-qualified syntax
('org.apache.solr.schema.numericRange.IntLongField'), or semi-qualified
('solr.numericrange.IntLongField'). This was quite awkward.
This commit adds the 'numericrange' subpackage to the special list used
by SRL, and cleans up the references to these field types to use the
preferred shorthand syntax.
anshumg
approved these changes
Mar 31, 2026
Contributor
Author
|
Note to self that 'test' and 'check' pass locally for me. Will aim to merge this EOW and then close out SOLR-13309 pending any review feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prior to this commit, the org.apache.solr.schema.numericrange subpackage was not in the list of packages that SolrResourceLoader uses to support the "shorthand" class syntax. As a result, references to these classes had to use fully-qualified syntax
('org.apache.solr.schema.numericRange.IntLongField'), or semi-qualified ('solr.numericrange.IntLongField'). This was quite awkward.
Solution
This commit adds the 'numericrange' subpackage to the special list used by SRL, and cleans up the references to these field types to use the preferred shorthand syntax.
No changelog entry is needed for this change since these field types haven't been released yet so there's no "change" here from a user's perspective.
Tests
Additional numeric-range field tests continue to pass. No new tests added.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.