SOLR-18270: cert auth plugin : add request attribute parametrization#4479
Closed
heitzjm wants to merge 4 commits into
Closed
SOLR-18270: cert auth plugin : add request attribute parametrization#4479heitzjm wants to merge 4 commits into
heitzjm wants to merge 4 commits into
Conversation
Contributor
|
This is not an authentication policy choice, it's an internal servlet details that does not need to be exposed to the user. |
Author
|
Fine, I am going to implement the fallback in the PR 4474. However, to me,
the attribute name is not an internal servlet detail : it is a kind of
"contract" between the application server and the application - and the
attribute name appears in specs (Jakarta Servlet Specifications -
https://jakarta.ee/specifications/servlet/). So, I think it would be great
to add a comment in the CertAuthPlugin documentation about it. In fact, it
was difficult for me to find out what went wrong, so adding a note about
the importance of the spec might help other users in some (I hope unlikely)
use cases. What do you think?
Le lun. 1 juin 2026 à 18:09, Lamine ***@***.***> a écrit :
… *laminelam* left a comment (apache/solr#4479)
<#4479 (comment)>
This is not an authentication policy choice, it's an internal servlet
details that does not need to be exposed to the user.
I think, your other PR <#4474> is more
appropriate to solve the issue.
—
Reply to this email directly, view it on GitHub
<#4479?email_source=notifications&email_token=AVJXZPBF2S5ZMMOMRWWWPG345WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4594366257>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVJXZPA4UKESNOMQVTFJUVL45WTELAVCNFSM6AAAAACZT5OZBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKOJUGM3DMMRVG4>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AVJXZPDDYQWDJTJU56J7QIL45WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AVJXZPD4INOLKRIIJPBNXNL45WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
As #4474 seems to be more appropriate, I closed this PR in favor to the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-18270
Description
The parameter used by the cert auth plugin to get the SSL client certificate can be configured in security.json, as the attribute name changed (java EE => jakarta EE)
Solution
This PR adds the parameter and its usage, as well as adds some tests, and updates the documentation.
Tests
Class solr/core/src/test/org/apache/solr/security/CertAuthPluginRequestAttributeTest.java : adds parametrized test to ensure that the default value works, and that a custom value is taken into account. The class heavily borrows code from solr/core/src/test/org/apache/solr/security/CertAuthPluginTest.java
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.The test failed because of a timeout. I reran the test only after that, and it then succeeded.