SOLR-18251: Introduced docValuesSkipList='true' field property#4509
SOLR-18251: Introduced docValuesSkipList='true' field property#4509VadimKirilchuk wants to merge 3 commits into
Conversation
|
I have already created PR #4458 for this, but I forgot to link it to the JIRA issue. The initial implementation enables it only for PointField. I’m currently working on benchmarks to determine whether it provides any meaningful improvement for range queries. |
dsmiley
left a comment
There was a problem hiding this comment.
Not sure how to reconcile the fact that we have 2 competing PRs...
| * include a range skip index for more efficient range queries. Otherwise, it creates standard | ||
| * DocValues fields. | ||
| */ | ||
| public final class DocValuesFieldUtil { |
There was a problem hiding this comment.
This is debatable to exist at all... I wonder if relevant methods can't by on FieldType.
My preference is to remove this class altogether.
Well, need to merge the best of both worlds/PRs I guess. I'll resolve your comment for DocValuesUtil and see what I can pull from the other PR, overall I think they are pretty similar. |
https://issues.apache.org/jira/browse/SOLR-18251
Description
Introduced docValuesSkipList='true' field property to allow creating DocValues Field instances with optional skip list index support, improving query performance.
Solution
Added a new boolean field property docValuesSkipList that can be set to true in schema field definitions (only fields supporting Numeric, Sorted Numeric, Sorted and Sorted Set doc value types). When enabled, Solr creates DocValues fields with an additional skip index, which enables more efficient range queries on DocValues. When not set (default false), standard DocValues fields are created without the skip index.
Changes include:
Tests
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.