[Build] Gitignore flatten-maven-plugin generated POM files#4444
Merged
Conversation
Remove committed .flattened-pom.xml build artifacts and ignore them
going forward, matching Apache SeaTunnel's ${revision} workflow.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*.flattened-pom.xmlto.gitignore.flattened-pom.xmlbuild artifacts introduced in [Build] Switch to 3.0.0-SNAPSHOT using Maven revision property #4426Closes #4443
Motivation
flatten-maven-plugingenerates.flattened-pom.xmlduring Maven builds to resolve${revision}for install/deploy. These files are build outputs (similar totarget/) and should not live in Git.This aligns StreamPark with Apache SeaTunnel's
${revision}workflow: keep the plugin, ignore the generated files.Test plan
git statusis clean after./mvnw -Pfast -DskipTests -pl streampark-common -am validateMade with Cursor