Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
28f4338
added jupyter notebook panel iframe logic
zyratlo May 28, 2026
90cfe7a
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jun 1, 2026
0025b07
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jun 5, 2026
2728d9b
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jun 9, 2026
b6a49ca
Merge branch 'refs/heads/main' into migration-tool-jupyter-panel
zyratlo Jun 15, 2026
c79b90c
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 20, 2026
80fcc96
Merge remote-tracking branch 'upstream/main' into migration-tool-jupy…
zyratlo Jul 23, 2026
ffaa007
convert jupyter notebook panel spec to vitest
zyratlo Jul 23, 2026
29c7a68
import standalone jupyter notebook panel component in spec instead of…
zyratlo Jul 23, 2026
91e1407
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 27, 2026
3c6d726
keep panel stream alive when iframe url fetch fails
zyratlo Jul 27, 2026
c3a69fe
stop logging jupyter iframe error when panel is hidden
zyratlo Jul 27, 2026
bdd42ba
fix jupyter panel delete button hover selector
zyratlo Jul 27, 2026
42277e0
drop unnecessary browsermodule from jupyter panel spec
zyratlo Jul 27, 2026
05f99d3
use fakeasync for jupyter checkiframeref timing tests
zyratlo Jul 27, 2026
6cb1ef4
gate jupyter iframe render on available url
zyratlo Jul 27, 2026
e6220d9
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 28, 2026
cdd646e
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 29, 2026
a11a4f9
clear jupyter panel url on hide and failed fetch
zyratlo Jul 29, 2026
f113582
restrict jupyter panel drag to header handle
zyratlo Jul 29, 2026
3a53462
drive jupyter panel visibility from service observable
zyratlo Jul 29, 2026
82d2c41
mount jupyter notebook panel in workspace shell
zyratlo Jul 29, 2026
fd558ad
assert sanitizer call instead of serialized url in jupyter panel spec
zyratlo Jul 29, 2026
44679a9
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 30, 2026
de690ab
implement jupyter notebook deletion from panel delete button
zyratlo Jul 31, 2026
3aa1b6e
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 31, 2026
730551d
Merge remote-tracking branch 'origin/migration-tool-jupyter-panel' in…
zyratlo Jul 31, 2026
e0059b4
add hover tooltips and change color of minimize/delete buttons
zyratlo Jul 31, 2026
614fe5e
cover jupyter panel minimize and delete button template bindings
zyratlo Jul 31, 2026
91f6554
restore missing NzTooltipModule import in jupyter panel component
zyratlo Jul 31, 2026
0d033de
show jupyter expand button immediately after in-place notebook import
zyratlo Jul 31, 2026
737e374
Merge branch 'main' into migration-tool-jupyter-panel
zyratlo Jul 31, 2026
f3671b9
treat default wid 0 as unsaved in jupyter notebook delete
zyratlo Jul 31, 2026
34757cf
cover notebook migration delete request in service spec
zyratlo Jul 31, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

<div
class="draggable-panel"
*ngIf="isVisible"
cdkDrag
cdkDragBoundary="texera-workspace">
<div
class="panel-header"
cdkDragHandle>
<span>Jupyter Notebook</span>
<div class="panel-buttons">
<!-- Minimize button -->
<button
class="minimize-button"
nz-tooltip
nzTooltipTitle="Minimize"
(click)="minimizePanel()">
<i
nz-icon
nzType="minus"
nzTheme="outline"></i>
</button>
<!-- Delete button -->
<button
class="delete-button"
nz-tooltip
nzTooltipTitle="Delete notebook"
nz-popconfirm
nzPopconfirmTitle="Delete this workflow's Jupyter notebook? This cannot be undone."
(nzOnConfirm)="deletePanel()">
<i
nz-icon
nzType="delete"
nzTheme="outline"></i>
</button>
</div>
</div>

<div class="iframe-container">
<iframe
*ngIf="jupyterUrl"
#iframeRef
[src]="jupyterUrl"
title="Jupyter Notebook"
width="100%"
height="100%"
style="border: none"></iframe>
</div>
</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

.draggable-panel {
position: absolute;
top: 50%;
left: 50%;
margin-top: 200px;
width: 660px;
height: 400px;
background-color: #fff;
box-shadow: 0 1px 5px rgba(0, 0, 0, 0.3);
border: 1px solid #ccc;
border-radius: 5px;
z-index: 1000;
resize: both;
overflow: auto;
}

.panel-header {
display: flex;
justify-content: space-between;
align-items: center;
background-color: #547baa;
color: white;
padding: 5px 10px 5px 10px;
font-weight: bold;
text-align: center;
cursor: move;
}

.panel-buttons {
display: flex;
align-items: center;
gap: 8px;
}

.minimize-button,
.delete-button {
background: none;
border: none;
color: white;
font-size: 16px;
cursor: pointer;
}

.minimize-button:hover,
.delete-button:hover {
color: #bfbfbf;
}

.iframe-container {
width: 100%;
height: calc(100% - 40px); /* Adjust height for the header */
}

.iframe-container iframe {
width: 100%;
height: 100%;
border: none;
}
Loading
Loading