refactor(frontend): extract Data Card and Versions & Files tabs - #7043
Conversation
…& Files tabs Adds a Data Card overview tab alongside the existing file browser (now under Versions & Files): a read-only description, an at-a-glance stats list (Created, Last updated, Versions, Latest version file, Selected version size), laid out as two side-by-side cards matching the app's card conventions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Automated Reviewer SuggestionsBased on the
|
…veLatestVersionFile
|
/request-review @xuang7 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7043 +/- ##
============================================
+ Coverage 79.57% 79.60% +0.03%
- Complexity 3832 3836 +4
============================================
Files 1159 1159
Lines 46122 46162 +40
Branches 5127 5133 +6
============================================
+ Hits 36700 36747 +47
+ Misses 7790 7787 -3
+ Partials 1632 1628 -4
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ttps://github.com/rbelavadi/texera into refactor/6942-extract-data-card-versions-files-tabs
There was a problem hiding this comment.
Pull request overview
Refactors the Angular dataset detail page in the frontend dashboard by splitting responsibilities across tabs, aiming to reduce clutter and separate read-only dataset metadata from file/version management workflows.
Changes:
- Introduces a read-only Data Card tab that surfaces dataset description and key facts.
- Moves the existing file browser/version selector/upload UI into a new Versions & Files tab.
- Adds component logic + unit tests to derive “latest version” facts independently from the currently selected version.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.ts |
Adds latest-version state and retrieval logic; hardens file-tree selection against empty trees. |
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.html |
Splits UI into Data Card vs Versions & Files tab content; adjusts Settings hint text. |
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.scss |
Adds layout and scrolling styles for the new tab contents and Data Card cards. |
frontend/src/app/dashboard/component/user/user-dataset/user-dataset-explorer/dataset-detail.component.spec.ts |
Adds/updates unit tests for Data Card latest-version behavior and tab-rendering implications. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ct-data-card-versions-files-tabs
…ng stub, test assertion)
What changes were proposed in this PR?
Extracts the remaining content on the dataset detail page into two new tabs: Data Card and Versions & Files. Part of #6394; second of two sub-issues (#6395, Settings, already merged).
texera-markdown-descriptioncomponent's built-in "View more" collapse for long descriptions.Before: two tabs- Data Card (holding everything: file browser, version history, uploads, plus a duplicated description in the header) and Settings.
After: three tabs- Data Card (read-only overview only), Versions & Files (file/version management, split out of the old Data
Card tab), and Settings (unchanged).
Any related issues, documentation, discussions?
Closes #6942
How was this PR tested?
Added 7 unit tests to
dataset-detail.component.spec.tscovering the new Data Card logic:retrieveLatestVersionFile()correctly resolves the latest version's file name, including nested paths and the no-files case.Manually tested on UI:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)