test(amber): add unit test coverage for AdminExecutionResource - #7165
Merged
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ScalaTest unit coverage for the Amber admin execution dashboard resource (AdminExecutionResource) using the existing MockTexeraDB embedded-Postgres pattern, without modifying production code.
Changes:
- Introduces
AdminExecutionResourceSpecto exercise the pure status-code mapping helpers (mapToName,mapToStatus). - Adds DB-backed tests for
getTotalWorkflowsandlistWorkflows(access flag, latest execution selection, status filtering, and a basic sorting invocation).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 397 | 0.242 | 23,949/36,925/36,925 us | 🔴 +18.1% / 🔴 +133.9% |
| 🔴 | bs=100 sw=10 sl=64 | 933 | 0.569 | 106,094/124,791/124,791 us | 🔴 +5.8% / 🔴 +13.1% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,106 | 0.675 | 904,075/947,673/947,673 us | ⚪ within ±5% / 🟢 -11.8% |
Baseline details
Latest main 45b7b20 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 397 tuples/sec | 449 tuples/sec | 771.62 tuples/sec | -11.6% | -48.5% |
| bs=10 sw=10 sl=64 | MB/s | 0.242 MB/s | 0.274 MB/s | 0.471 MB/s | -11.7% | -48.6% |
| bs=10 sw=10 sl=64 | p50 | 23,949 us | 22,342 us | 12,626 us | +7.2% | +89.7% |
| bs=10 sw=10 sl=64 | p95 | 36,925 us | 31,270 us | 15,786 us | +18.1% | +133.9% |
| bs=10 sw=10 sl=64 | p99 | 36,925 us | 31,270 us | 19,344 us | +18.1% | +90.9% |
| bs=100 sw=10 sl=64 | throughput | 933 tuples/sec | 982 tuples/sec | 971.56 tuples/sec | -5.0% | -4.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.569 MB/s | 0.6 MB/s | 0.593 MB/s | -5.2% | -4.0% |
| bs=100 sw=10 sl=64 | p50 | 106,094 us | 100,310 us | 103,463 us | +5.8% | +2.5% |
| bs=100 sw=10 sl=64 | p95 | 124,791 us | 123,304 us | 110,296 us | +1.2% | +13.1% |
| bs=100 sw=10 sl=64 | p99 | 124,791 us | 123,304 us | 118,690 us | +1.2% | +5.1% |
| bs=1000 sw=10 sl=64 | throughput | 1,106 tuples/sec | 1,106 tuples/sec | 1,001 tuples/sec | 0.0% | +10.5% |
| bs=1000 sw=10 sl=64 | MB/s | 0.675 MB/s | 0.675 MB/s | 0.611 MB/s | 0.0% | +10.4% |
| bs=1000 sw=10 sl=64 | p50 | 904,075 us | 901,045 us | 1,008,988 us | +0.3% | -10.4% |
| bs=1000 sw=10 sl=64 | p95 | 947,673 us | 964,966 us | 1,055,260 us | -1.8% | -10.2% |
| bs=1000 sw=10 sl=64 | p99 | 947,673 us | 964,966 us | 1,074,689 us | -1.8% | -11.8% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,503.58,200,128000,397,0.242,23948.95,36925.35,36925.35
1,100,10,64,20,2144.42,2000,1280000,933,0.569,106094.16,124790.70,124790.70
2,1000,10,64,20,18087.00,20000,12800000,1106,0.675,904075.24,947673.27,947673.27
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7165 +/- ##
============================================
+ Coverage 79.62% 79.78% +0.16%
- Complexity 3836 3838 +2
============================================
Files 1160 1160
Lines 46188 46188
Branches 5145 5145
============================================
+ Hits 36777 36852 +75
+ Misses 7778 7691 -87
- Partials 1633 1645 +12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Reword the random-id comment: MockTexeraDB's embedded Postgres is a JVM singleton and suites run sequentially, so the ids guard against cross-suite data residue, not parallel execution. - Strengthen the sorting test to seed a second workflow with a distinct end time and assert the ascending/descending order, instead of only asserting the call does not throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Adds a spec for
AdminExecutionResource(
amber/src/main/scala/org/apache/texera/web/resource/dashboard/admin/execution/AdminExecutionResource.scala),which had no test coverage. The resource is jOOQ-backed, so the spec runs against
embedded Postgres via
MockTexeraDB(the established unit pattern, mirroringWorkflowExecutionsResourceSpec). No production code was changed.8 tests:
mapToName/mapToStatus— the pure status-code lookups, covering every knowncode and the default (
"UNKNOWN"/-1); no DB needed.getTotalWorkflows— returns 0 with no executions, and counts distinctworkflows (two executions on one workflow still count as one).
listWorkflows— seeds a user, workflow, version and executions, then asserts:the returned row's fields (name, owner, mapped status, execution name); the
accessflag derived fromWORKFLOW_USER_ACCESS(true with a grant, falsewithout); that only the latest execution per workflow is returned; that the
status filter narrows the result; and that providing a sort field still returns
the row.
Any related issues, documentation, discussions?
Closes #7160
How was this PR tested?
Unit tests, run locally against embedded Postgres (
MockTexeraDB). All pass, andthe failure path was verified by breaking an assertion to confirm the suite goes
red:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])