[Fix] Add origins option to requestFileHandle#19960
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the requestFileHandle call in web/src/artifact_cache.ts to include an origins option. However, the CrossOriginStorageRequestFileHandleOptions interface needs to be updated to include this new property to avoid a TypeScript compilation error.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
origins option to requestFileHandleorigins option to requestFileHandle
|
By the way, we also now offer TypeScript types. |
|
@akaashrp This PR may be quick to review for you? |
|
Thanks @tomayac, could you retrigger CI? |
|
CI fails, but I don't think because of me 🫣?! |
This makes the resources available globally. Initially this wasn't implemented in the extension, but the origins check is implemented now, so we need to update the code to make use of it. (Internally, the extension as a one-off upgrades all resources that were stored already as origins: '*'.)