Skip to content

[DLight] Fix GPU reduction ScheduleError on 4D non-last-axis reductions#19984

Draft
cchung100m wants to merge 1 commit into
apache:mainfrom
cchung100m:issue-19517
Draft

[DLight] Fix GPU reduction ScheduleError on 4D non-last-axis reductions#19984
cchung100m wants to merge 1 commit into
apache:mainfrom
cchung100m:issue-19517

Conversation

@cchung100m

Copy link
Copy Markdown
Contributor

Hi Committers,

This PR fixes issue #19517. Any suggestions would be appreciated if you are available.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the robustness of the GPU reduction scheduling in dlight by dynamically identifying spatial and reduction loops based on their iteration types rather than assuming a fixed structure. It also introduces validation checks to safely return None if the loop structure does not match expectations. The review feedback points out a minor parenthesis typo in a newly added comment block.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread python/tvm/s_tir/dlight/gpu/reduction.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant