[ZEPPELIN-6358] Add E2E test coverage for notebook components#5181
Merged
jongyoul merged 7 commits intoapache:masterfrom Apr 4, 2026
Merged
[ZEPPELIN-6358] Add E2E test coverage for notebook components#5181jongyoul merged 7 commits intoapache:masterfrom
jongyoul merged 7 commits intoapache:masterfrom
Conversation
jongyoul
approved these changes
Mar 20, 2026
Member
|
Merged into master (5e9847b). |
jongyoul
pushed a commit
that referenced
this pull request
Apr 4, 2026
### What is this PR for? This is the final PR in the series derived from #5101. Notebook features had zero E2E coverage. This adds 20 spec files (~3500 lines). **Notebook core** - `notebook-container` — structure, action bar presence, sidebar width constraints, paragraph grid layout, extension area - `action-bar-functionality` — run all, code/output toggle, clear output, clone/export/reload, collaboration mode, revision controls, scheduler, settings group - `notebook-keyboard-shortcuts` — full ShortcutsMap coverage (Monaco editor; serial because Monaco holds focus state between tests — isolating via `beforeEach` wasn't viable) - `sidebar-functionality` — TOC panel, file tree panel, open/close state transitions - `paragraph-functionality` — edit mode, run/cancel, dynamic forms, footer DOM presence **Share features** - `folder-rename` — hover context menu, rename modal, validation, delete confirmation, folder merge on name collision - `note-rename` — inline title editing, enter/blur/escape flows, empty name rejection, special characters - `note-toc` — panel open/close, empty state message, toggle button attributes, repeated toggle #### Pulled in test failure fixes from #5180 - Cleaned up `about-zeppelin-modal` and `note-create-modal` specs and models - Added missing aria attributes and `data-testid` selectors to `action-bar.component.html` - Bumped `flatted` 3.3.3 → 3.4.1 (npm audit) ### What type of PR is it? Improvement Feature Documentation ### Todos ### What is the Jira issue? ZEPPELIN-6358 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5181 from dididy/e2e/notebook-final. Signed-off-by: Jongyoul Lee <jongyoul@gmail.com> (cherry picked from commit 5e9847b) Signed-off-by: Jongyoul Lee <jongyoul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is the final PR in the series derived from #5101.
Notebook features had zero E2E coverage. This adds 20 spec files (~3500 lines).
Notebook core
notebook-container— structure, action bar presence, sidebar width constraints, paragraph grid layout, extension areaaction-bar-functionality— run all, code/output toggle, clear output, clone/export/reload, collaboration mode, revision controls, scheduler, settings groupnotebook-keyboard-shortcuts— full ShortcutsMap coverage (Monaco editor; serial because Monaco holds focus state between tests — isolating viabeforeEachwasn't viable)sidebar-functionality— TOC panel, file tree panel, open/close state transitionsparagraph-functionality— edit mode, run/cancel, dynamic forms, footer DOM presenceShare features
folder-rename— hover context menu, rename modal, validation, delete confirmation, folder merge on name collisionnote-rename— inline title editing, enter/blur/escape flows, empty name rejection, special charactersnote-toc— panel open/close, empty state message, toggle button attributes, repeated togglePulled in test failure fixes from #5180
about-zeppelin-modalandnote-create-modalspecs and modelsdata-testidselectors toaction-bar.component.htmlflatted3.3.3 → 3.4.1 (npm audit)What type of PR is it?
Improvement
Feature
Documentation
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
Screenshots (if appropriate)
Questions: