docs(agent-collab): document sideload tag aliasing trap and two exits#225
Merged
Conversation
…mage handoff guide When sideloading a patch container image into a node where the same image already had another tag (typically a base tag), the runtime keeps both tags pointing at the same digest. kubelet may report any of those tags on pod status.Image, not necessarily the tag in PodSpec. With a chart that references the image by tag, this causes InstanceSet controller's strict tag string comparison in isImageMatched to fail, and the InstanceSet does not mark ready, even though the running image data is correct. Document the trap and the two operational exits: 1. Drop the base/old tag alias from the runtime so the patch tag is the only tag kubelet can surface (e.g. ctr -n k8s.io image rm <old-tag>). 2. Pin the chart image reference to a digest. InstanceSet controller's main-branch isImageMatched already consults status.ImageID as the canonical digest source for digest-pinned specs. Either exit closes via the existing pod imageID equals build sha verification rule, not via 'pod is up'.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sideload + tag 别名陷阱section todocs/agent-collab/addon-patch-image-build-handoff-roles-guide.md.Why
Addon teams sometimes sideload controller patch images when registry push is unavailable. If the node runtime keeps both the base tag and patch tag for the same digest, kubelet may surface either tag in
pod.status.containerStatuses[*].Image. With tag-only specs, InstanceSet strict tag-string comparison can then keep the InstanceSet from marking ready even when the running image data is the intended patch digest.Test plan
git diff --check origin/main...HEAD