Skip to content

fix(dataprotection): record post-ready stage errors#10619

Draft
weicao wants to merge 1 commit into
mainfrom
bugfix/dp-postready-error-stage
Draft

fix(dataprotection): record post-ready stage errors#10619
weicao wants to merge 1 commit into
mainfrom
bugfix/dp-postready-error-stage

Conversation

@weicao

@weicao weicao commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Fixes #10617

Summary

  • pass the PostReady stage to restore stage error handling
  • inspect the condition that belongs to the failing restore stage
  • cover a postReady-only fatal error without creating a PreparedData condition

Tests

  • focused postReady fatal-error spec
  • go test ./controllers/dataprotection -count=1
  • go vet ./controllers/dataprotection
  • git diff --check

@apecloud-bot

Copy link
Copy Markdown
Collaborator

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

@github-actions github-actions Bot added the size/M Denotes a PR that changes 30-99 lines. label Jul 11, 2026
@weicao weicao added the nopick Not auto cherry-pick when PR merged label Jul 11, 2026
@codecov

codecov Bot commented Jul 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.85%. Comparing base (5a57a85) to head (33e81d2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10619      +/-   ##
==========================================
+ Coverage   63.75%   63.85%   +0.10%     
==========================================
  Files         520      520              
  Lines       62957    62961       +4     
==========================================
+ Hits        40138    40204      +66     
+ Misses      19201    19165      -36     
+ Partials     3618     3592      -26     
Flag Coverage Δ
unittests 63.85% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nopick Not auto cherry-pick when PR merged size/M Denotes a PR that changes 30-99 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataProtection records post-ready errors on the prepare-data stage

2 participants