fix(dataprotection): label backup workloads for cleanup#10672
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10672 +/- ##
==========================================
+ Coverage 63.97% 64.34% +0.37%
==========================================
Files 520 520
Lines 62887 63298 +411
==========================================
+ Hits 40229 40730 +501
+ Misses 19071 19000 -71
+ Partials 3587 3568 -19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10675
What problem does this solve?
Backup-owned Jobs and continuous backup StatefulSets could inherit a non-DataProtection
app.kubernetes.io/managed-bylabel from the parent Backup. DataProtection watch and cleanup selectors requirekubeblocks-dataprotection, so those workloads could be missed.What is changed?
BuildBackupWorkloadLabelsto setmanaged-by=kubeblocks-dataprotectionafter copying parent labels.Existing workloads with the historical wrong label are not migrated by this change.
Validation
pkg/dataprotection/backupandcontrollers/dataprotectiontestsgo vet, lint, generated-file checks, and fullmake check-diff