fix(api7): correct file-server image tag and pullPolicy#275
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR increments the api7 Helm chart version and updates the file_server image defaults: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/api7/values.yaml (1)
92-92: Optional: ConsiderpullPolicy: IfNotPresentfor pinned versions.Using
pullPolicy: Alwayswith a pinned version tag like"v3.9.8"means Kubernetes will attempt to pull the image on every pod start, even though the tag won't change. This can increase startup time and may cause issues if the registry is temporarily unavailable.Since this pattern is used consistently across all components (dashboard, dp_manager, developer_portal), this is a broader architectural question rather than an issue specific to this PR. If frequent image pulls aren't needed for operational reasons (e.g., ensuring registry availability, detecting image corruption), consider evaluating
IfNotPresentfor all pinned-version deployments as a future optimization.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@charts/api7/values.yaml` at line 92, The current image pullPolicy is set to Always (pullPolicy: Always) for pinned version tags; update the values in charts/api7/values.yaml (and the matching entries for dashboard, dp_manager, developer_portal) to use pullPolicy: IfNotPresent for pinned tags like "v3.9.8" so Kubernetes will use local images when present and avoid unnecessary registry pulls; keep Always only for tags that are mutable (e.g., :latest) or when you explicitly need to force pulls.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@charts/api7/values.yaml`:
- Line 92: The current image pullPolicy is set to Always (pullPolicy: Always)
for pinned version tags; update the values in charts/api7/values.yaml (and the
matching entries for dashboard, dp_manager, developer_portal) to use pullPolicy:
IfNotPresent for pinned tags like "v3.9.8" so Kubernetes will use local images
when present and avoid unnecessary registry pulls; keep Always only for tags
that are mutable (e.g., :latest) or when you explicitly need to force pulls.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: daa01513-a338-4634-8908-b779afd05c9b
📒 Files selected for processing (2)
charts/api7/README.mdcharts/api7/values.yaml
- Change file_server.image.tag from 'dev' to 'v3.9.8' - Change file_server.image.pullPolicy from 'IfNotPresent' to 'Always' (consistent with other components) - Bump api7 chart version: 0.17.49 -> 0.17.50
jarvis9443
force-pushed
the
nic/fix-file-server-tag
branch
from
5e46dbf to
7cd137c
Compare
2 participants
Changes
Fix file-server image configuration introduced in #274:
file_server.image.tag:dev→v3.9.8(file-server is released with v3.9.8)file_server.image.pullPolicy:IfNotPresent→Always(consistent with dashboard, dp_manager, developer_portal)Summary by CodeRabbit