fix(openapi): add missing ad-hoc webhook fields to WebhookRepresentation#2640
Open
vdusek wants to merge 1 commit into
Open
fix(openapi): add missing ad-hoc webhook fields to WebhookRepresentation#2640vdusek wants to merge 1 commit into
vdusek wants to merge 1 commit into
Conversation
Contributor
|
✅ Preview for this PR (commit |
Contributor
|
Important Action required — @vdusek please coordinate this docs PR with the Python API client PR linked below. Because this PR modifies the OpenAPI specification, the generated models in A companion PR has been opened in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WebhookRepresentationschema (items of the Base64-encodedwebhooksquery parameter on the run/build endpoints) declared onlyeventTypes,requestUrl,payloadTemplateandheadersTemplate, but the platform accepts and honors more fields for ad-hoc webhooks: the run-start handler spreads each webhook object into the sameinsertWebhookpath used by the create-webhook endpoint, including theidempotencyKeydedup logic.idempotencyKey,ignoreSslErrorsanddoNotRetryproperties to the schema, so generated API clients (e.g.apify-client-python) stop dropping them.