fix: Bump typing-extensions floor to 4.4.0#960
Open
vdusek wants to merge 1 commit into
Open
Conversation
The codebase imports `override` (added in typing_extensions 4.4.0), so a minimal resolution with the previous 4.1.0 floor fails at import.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 90.00% 90.04% +0.03%
==========================================
Files 49 49
Lines 3053 3053
==========================================
+ Hits 2748 2749 +1
+ Misses 305 304 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codebase imports
overridefromtyping_extensionsin ten modules (andUnpackinevents/_apify_event_manager.py), butoverridewas only added in typing_extensions 4.4.0. With the previous>=4.1.0floor, a minimal dependency resolution fails at import time. This bumps the floor to>=4.4.0, the accurate minimum for the features actually used.