Skip to content

fix: Bump typing-extensions floor to 4.4.0#960

Open
vdusek wants to merge 1 commit into
masterfrom
fix/typing-extensions-floor
Open

fix: Bump typing-extensions floor to 4.4.0#960
vdusek wants to merge 1 commit into
masterfrom
fix/typing-extensions-floor

Conversation

@vdusek

@vdusek vdusek commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

The codebase imports override from typing_extensions in ten modules (and Unpack in events/_apify_event_manager.py), but override was only added in typing_extensions 4.4.0. With the previous >=4.1.0 floor, a minimal dependency resolution fails at import time. This bumps the floor to >=4.4.0, the accurate minimum for the features actually used.

The codebase imports `override` (added in typing_extensions 4.4.0), so a minimal resolution with the previous 4.1.0 floor fails at import.
@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Jun 11, 2026
@vdusek vdusek self-assigned this Jun 11, 2026
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.04%. Comparing base (a87e8d1) to head (4ed1db8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
+ Coverage   90.00%   90.04%   +0.03%     
==========================================
  Files          49       49              
  Lines        3053     3053              
==========================================
+ Hits         2748     2749       +1     
+ Misses        305      304       -1     
Flag Coverage Δ
e2e 35.66% <ø> (ø)
integration 56.89% <ø> (+0.03%) ⬆️
unit 78.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek vdusek requested a review from Pijukatel June 11, 2026 12:25
@vdusek vdusek marked this pull request as ready for review June 11, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants