refactor!: Align DatasetClient and KeyValueStoreClient interfaces with their Python counterparts#3627
Open
janbuchar wants to merge 2 commits into
Open
refactor!: Align DatasetClient and KeyValueStoreClient interfaces with their Python counterparts#3627janbuchar wants to merge 2 commits into
DatasetClient and KeyValueStoreClient interfaces with their Python counterparts#3627janbuchar wants to merge 2 commits into
Conversation
janbuchar
added
the
t-tooling
janbuchar
changed the title
DatasetClient and KeyValueStoreClient interfaces with their Python counterparts
barjin
reviewed
May 11, 2026
Member
barjin
left a comment
barjin
left a comment
There was a problem hiding this comment.
Thank you @janbuchar ! Few ideas below ⬇️
| * @ignore | ||
| */ | ||
| export function checkAndSerialize<T>(item: T, limitBytes: number, index?: number): string { | ||
| export function isJsonSerializable<T>(item: T, index?: number): void { |
Member
There was a problem hiding this comment.
A method called >>is<<JsonSerializable should imo return a Boolean... I certainly wouldn't expect it to throw as a part of the "happy" path.
janbuchar
force-pushed
the
simplify-storage-subclients
branch
from
d998bc7 to
1e349f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageClientinterface - this handles the "subclients"RequestQueueClientis left for Move Apify RequestQueue-specific logic to SDK #3328