fix: BrowserCrawler closes ctx.page before errorHandler runs on navigation errors (#3647)#3648
Open
moaedy wants to merge 1 commit into
Open
fix: BrowserCrawler closes ctx.page before errorHandler runs on navigation errors (#3647)#3648moaedy wants to merge 1 commit into
moaedy wants to merge 1 commit into
Conversation
moaedy
force-pushed
the
godfix/issue-3647-run-6
branch
from
da68c9b to
d3a29d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause:
BrowserCrawler._handleNavigationTimeoutwas called on every navigation error but unconditionally closedcrawlingContext.page, racing usererrorHandleraccess and duplicating the close already performed by_cleanupContextin thefinallyof_runRequestFunction. Change: Moved theawait crawlingContext.page.close()inside the existingTimeoutErrorbranch of_handleNavigationTimeoutinpackages/browser-crawler/src/internals/browser-crawler.ts, so eager close only fires when there is a hung page to release. Closes #3647