Skip to content

LTI1.3 tool: Create lineitem if not found while sending grade#1516

Open
murhum1 wants to merge 1 commit intoapluslms:masterfrom
murhum1:fix_lti_lineitem_not_found
Open

LTI1.3 tool: Create lineitem if not found while sending grade#1516
murhum1 wants to merge 1 commit intoapluslms:masterfrom
murhum1:fix_lti_lineitem_not_found

Conversation

@murhum1
Copy link
Copy Markdown
Contributor

@murhum1 murhum1 commented Apr 10, 2026

Fix for the issue where after some moodle operations grades would no longer be sent from A+ to moodle. Now lineitem existence is checked before trying to send the grade, and is recreated if not found.

Fixes #1483

Testing

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

Tested manually removing a lineitem created by A+ and trying to submit the associated exercise before and after changes, verifying that the error happened before the change and no longer after the change.

Also tested that no duplicate lineitems were created if one already existed, e.g. tested submitting without manually removing the lineitem beforehand, as well as doing multiple submissions to the exercise.

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Fix for the issue where after some moodle operations grades would
no longer be sent from A+ to moodle. Now lineitem existence is
checked before trying to send the grade, and is recreated if not
found.
@ihalaij1 ihalaij1 self-requested a review April 10, 2026 07:22
Copy link
Copy Markdown
Contributor

@ihalaij1 ihalaij1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this issue nor do I know how to test it. But looks like you tested it already so I'm going to approve.

Also, could you add Fixes #1483 to the commit message footer before merging?

@ihalaij1 ihalaij1 moved this to In progress in A+ sprints Apr 10, 2026
@ihalaij1 ihalaij1 moved this from In progress to Under review in A+ sprints Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Under review

Development

Successfully merging this pull request may close these issues.

Figure out a way of handling LTI error situations

2 participants