LTI1.3 tool: Create lineitem if not found while sending grade#1516
Open
murhum1 wants to merge 1 commit intoapluslms:masterfrom
Open
LTI1.3 tool: Create lineitem if not found while sending grade#1516murhum1 wants to merge 1 commit intoapluslms:masterfrom
murhum1 wants to merge 1 commit intoapluslms:masterfrom
Conversation
Fix for the issue where after some moodle operations grades would no longer be sent from A+ to moodle. Now lineitem existence is checked before trying to send the grade, and is recreated if not found.
ihalaij1
approved these changes
Apr 10, 2026
Contributor
ihalaij1
left a comment
There was a problem hiding this comment.
I'm not familiar with this issue nor do I know how to test it. But looks like you tested it already so I'm going to approve.
Also, could you add Fixes #1483 to the commit message footer before merging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue where after some moodle operations grades would no longer be sent from A+ to moodle. Now lineitem existence is checked before trying to send the grade, and is recreated if not found.
Fixes #1483
Testing
What type of test did you run?
Tested manually removing a lineitem created by A+ and trying to submit the associated exercise before and after changes, verifying that the error happened before the change and no longer after the change.
Also tested that no duplicate lineitems were created if one already existed, e.g. tested submitting without manually removing the lineitem beforehand, as well as doing multiple submissions to the exercise.
Did you test the changes in