feat: support selenium 4.44.0, refactor tests, and modernize code by kelmelzer · Pull Request #1053 · appium/dotnet-client

kelmelzer · 2026-05-13T18:57:46Z

List of changes

Bump and fix Selenium 4.44.0 breaking changes
Bump package versions in main and test projects
Update copyright year to 2026
Remove ICommandExecutor from AppiumLocalService
Modernize code with target-typed new and object initializers
Simplify exception handling and assertions in tests
Mark WindowsDriver.HideKeyboard as new
Refactor BiDiTests, PerformanceDataTests, WaitTests, and ClipboardTest for NUnit 4.6 compatibility
Make StickyNotesTest abstract and refactor session setup

Types of changes

What types of changes are you proposing/introducing to the .NET client?
Put an x in the boxes that apply

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change that adds functionality or value)
Breaking change (fix or feature that would cause existing functionality not to work as expected)
Test fix (non-breaking change that improves test stability or correctness)

Documentation

Have you proposed a file change/ PR with Appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

Have you provided integration tests for your changes? (required for Bugfix, New feature, or Test fix)

Details

Selenium 4.44.0 removed unnecessary ICommandExecutor interface and other changes which broke 8.2.0. I cleared out over a dozen IDE warnings and informational messages as well to modernize the codebase and tests.

- Bump and fix Selenium 4.44.0 breaking changes - Bump package versions in main and test projects - Update copyright year to 2026 - Remove ICommandExecutor from AppiumLocalService - Modernize code with target-typed new and object initializers - Simplify exception handling and assertions in tests - Mark WindowsDriver.HideKeyboard as new - Refactor BiDiTests, PerformanceDataTests, WaitTests, and ClipboardTest for NUnit 4.6 compatibility - Make StickyNotesTest abstract and refactor session setup

kelmelzer · 2026-05-13T22:27:53Z

This is failing on that new GetProperty Android test.

KazuCocoa · 2026-05-14T04:51:06Z

Could you update https://github.com/appium/dotnet-client#compatibility-matrix as well

Copilot

Pull request overview

This PR updates the .NET client and integration tests to accommodate Selenium WebDriver 4.44.0 changes, refreshes key dependency versions, and modernizes/refactors several test implementations for newer NUnit compatibility.

Changes:

Bump Selenium/WebDriver and test dependency versions; refresh package metadata (e.g., copyright year).
Refactor/modernize integration tests (NUnit 4.6 patterns, assertions, and newer C# syntax).
Update service/driver code to align with Selenium 4.44.0 API surface changes (e.g., remove legacy interface usage).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/integration/Windows/StickyNotesTest.cs	Makes the base test abstract and modernizes capability setup for Sticky Notes session management.
test/integration/ServerTests/StartingAppLocallyTest.cs	Simplifies exception handling in a service start/failed-session test.
test/integration/IOS/ClipboardTest.cs	Refactors assertions for NUnit 4.6 compatibility and simplifies some checks.
test/integration/Appium.Net.Integration.Tests.csproj	Updates NUnit/Microsoft.NET.Test.Sdk/TestAdapter/System.Text.Json package versions.
test/integration/Android/WaitTests.cs	Modernizes argument construction for `ExecuteScript` and fixes an assertion variable typo.
test/integration/Android/Device/PerformanceDataTests.cs	Updates `Assert.Multiple` usage to NUnit 4 style and adjusts constraints.
test/integration/Android/BiDiTests.cs	Updates BiDi field typing to the newer interface type.
src/Appium.Net/Appium/Windows/WindowsDriver.cs	Marks `HideKeyboard(string)` as `new` to explicitly hide the base member.
src/Appium.Net/Appium/Service/AppiumLocalService.cs	Removes Selenium Remote interface coupling and minor code modernization.
src/Appium.Net/Appium/Service/AppiumCommandExecutor.cs	Tightens immutability and simplifies exception handling.
src/Appium.Net/Appium.Net.csproj	Bumps core library package dependencies and updates package metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                        App = StickyNotesAppId,
+                        DeviceName = "WindowsPC",
+                        AutomationName = "Windows"
+                    };


    /// Represents a local Appium server service that can be started and stopped programmatically.
    /// </summary>
-    public class AppiumLocalService : ICommandServer
+    public class AppiumLocalService


- Use collection expressions and null-coalescing assignments - Refactor test assertions for NUnit compatibility - Comment out failing GetPropertyTest in ElementTest.cs - Update README.md with latest supported versions - Add missing IDisposable in AppiumLocalService - General code cleanup and style improvements

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

test/integration/Android/ElementTest.cs:86

There are stray semicolons after using (Assert.EnterMultipleScope()) { ... } blocks (e.g., };). These create empty statements and can trigger analyzers / reduce readability; remove the trailing semicolons so the block ends with }.

            using (Assert.EnterMultipleScope())
            {
                Assert.That(WaitForElement(_driver, MobileBy.Id("android:id/content")).FindElement(byAndroidUiAutomator).Text, Is.Not.Null);
                Assert.That(
                    WaitForElement(_driver, MobileBy.Id("android:id/content")).FindElements(byAndroidUiAutomator), Is.Not.Empty);
            };
        }

test/integration/Android/ElementTest.cs:66

The By byAndroidUiAutomator = ... declaration is on the same line as the preceding } which hurts readability and makes diffs noisy. Please put the By declaration on its own line after the CI skip block.

            if (Env.IsCiEnvironment())
            {
                Assert.Ignore("Skipping FindByAndroidUiAutomatorTest test in CI environment");
            }            By byAndroidUiAutomator = new ByAndroidUIAutomator("new UiSelector().clickable(true)");
            using (Assert.EnterMultipleScope())
            {

+            using (Assert.EnterMultipleScope())
            {
                Assert.That(androidDriver?.GetPerformanceData("logd", PerformanceDataType.CpuInfo),
-                            Is.Not.Null.Or.Empty,
+Is.Not.Null.And.Not.Empty,
                            "CPU Info data should not be null or empty");

                Assert.That(androidDriver?.GetPerformanceData("logd", PerformanceDataType.CpuInfo, 15),
-                            Is.Not.Null.Or.Empty,
+Is.Not.Null.And.Not.Empty,
                            "CPU Info data should not be null or empty after 15 read attempts");


+                    AppiumOptions desktopCapabilities = new()
+                    {
+                        App = "Root",
+                        DeviceName = "WindowsPC",
+                        AutomationName = "Windows"
+                    };
                    var desktopSession = new WindowsDriver(serverUri, desktopCapabilities);

                    var StickyNotesTopLevelWindow = desktopSession.FindElement(MobileBy.ClassName("Modern_Sticky_Top_Window"));
                    var StickyNotesTopLevelWindowHandle = StickyNotesTopLevelWindow.GetAttribute("NativeWindowHandle");
-                    StickyNotesTopLevelWindowHandle = (int.Parse(StickyNotesTopLevelWindowHandle)).ToString("x"); // Convert to Hex
+                    StickyNotesTopLevelWindowHandle = int.Parse(StickyNotesTopLevelWindowHandle).ToString("x"); // Convert to Hex


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Dor-bl · 2026-05-18T04:37:16Z

Unless that is necessary, I prefer to update those packages in a separate PR.

sure, i'll pull those and revert the NUnit modernizations...give me a bit

didn't need to revert any NUnit code with version reversion ;)

KazuCocoa requested a review from Copilot May 14, 2026 04:50

Copilot started reviewing on behalf of KazuCocoa May 14, 2026 04:51 View session

KazuCocoa changed the title ~~Selenium 4.44.0 fixes, etc.: Update dependencies, refactor tests, and modernize code~~ feat: support selenium 4.44.0, refactor tests, and modernize code May 14, 2026

Copilot AI reviewed May 14, 2026

View reviewed changes

github-actions Bot added the Enhancement label May 14, 2026

kelmelzer added 3 commits May 14, 2026 09:48

bumped test project to .net 10

84c7a9b

fixed missing capability in test

4f890db

revert back .net 8, will fix later

e3b8321

KazuCocoa requested a review from Copilot May 15, 2026 06:16

Copilot started reviewing on behalf of KazuCocoa May 15, 2026 06:17 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

kelmelzer and others added 2 commits May 15, 2026 09:34

Potential fix for pull request finding

8000d7e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

cleanup

e0c73fb

Dor-bl reviewed May 18, 2026

View reviewed changes

nvborisenko mentioned this pull request May 19, 2026

[🐛 Bug]: Compile error after updating to 4.44 (C#) SeleniumHQ/selenium#17516

Closed

3 tasks

revert test project package versions

d691ab3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support selenium 4.44.0, refactor tests, and modernize code#1053

feat: support selenium 4.44.0, refactor tests, and modernize code#1053
kelmelzer wants to merge 8 commits into
appium:mainfrom
kelmelzer:main

kelmelzer commented May 13, 2026

Uh oh!

kelmelzer commented May 13, 2026

Uh oh!

KazuCocoa commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Dor-bl May 18, 2026

Uh oh!

kelmelzer May 19, 2026

Uh oh!

kelmelzer May 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

kelmelzer commented May 13, 2026

List of changes

Types of changes

Documentation

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

Details

Uh oh!

kelmelzer commented May 13, 2026

Uh oh!

KazuCocoa commented May 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Dor-bl May 18, 2026

Choose a reason for hiding this comment

Uh oh!

kelmelzer May 19, 2026

Choose a reason for hiding this comment

Uh oh!

kelmelzer May 19, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants