[builder]: enable ssh forwarding for container build#1508
Open
saehejkang wants to merge 1 commit into
Open
Conversation
saehejkang
force-pushed
the
ssh-agent-access-build-commands
branch
from
ed08f5a to
acdc87e
Compare
JaewonHur
reviewed
May 20, 2026
| progress.set(tasks: 0) | ||
| progress.set(totalTasks: 3) | ||
|
|
||
| try await BuilderStart.start( |
Contributor
There was a problem hiding this comment.
Can't we remove this part as we already do BuilderStart.start in L180?
Contributor
Author
There was a problem hiding this comment.
I believe that the second start call is executed in case of an error with the first start call. Seems to be an extra set of redundancies for safety.
| // Ensure the builder is started (or restarted) with the correct SSH configuration | ||
| // before attempting to dial. This handles the case where the builder is already | ||
| // running but was not started with SSH forwarding enabled. | ||
| try await BuilderStart.start( |
Contributor
There was a problem hiding this comment.
Seems you fixed another bug by moving this here :)
Buildkit container was not being recreated when we change configuration.
Contributor
Author
There was a problem hiding this comment.
100% unintentional, I promise :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
Closes #1472 and depends on apple/container-builder-shim#76 for pipeline to ✅
Testing