Skip to content

Avoid copying embedding table in static shape runner #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blevine1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Avoid copying embedding table in static shape runner #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions swift/Sources/CoreAILanguageModels/InferenceEngines/CoreAIStaticShapeEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,23 +182,16 @@ public final class StaticShapeEngine: InferenceEngine, @unchecked Sendable {
throw InferenceRuntimeError.invalidState("Cannot load 'load_embeddings'")
}

guard case .ndArray(let embeddingDesc) = embeddingFunction.descriptor.outputDescriptor(of: "embedding_table")
var outputs = try await embeddingFunction.run(inputs: [:])
guard let embeddingTableValue = outputs.remove("embedding_table"),
let embeddingTableArray = embeddingTableValue.ndArray
else {
throw InferenceRuntimeError.invalidState(
"load_embeddings has no 'embedding_table' ndArray output descriptor")
"load_embeddings function should have output NDArray named embedding_table")
}
var embeddingArray = NDArray(descriptor: embeddingDesc)

var outputViews = InferenceFunction.MutableViews()
outputViews.insert(&embeddingArray, for: "embedding_table")

_ = try await embeddingFunction.run(
inputs: [:],
outputViews: consume outputViews
)

CLILogger.log("Embeddings loaded: shape=\(embeddingArray.shape)")
return embeddingArray
CLILogger.log("Embeddings loaded: shape=\(embeddingTableArray.shape)")
return embeddingTableArray
}

// MARK: - Function Loading (lazy)
Expand Down