refactor: add InvalidExecutionModeError for unknown execution modes#38
Merged
Merged
Conversation
Define InvalidExecutionModeError(ValueError) next to the ExecutionMode enum so callers can catch a single, dedicated exception type instead of matching on ad-hoc ValueError message strings.
Add the new exception to the public quantization package surface alongside ExecutionMode.
Replace the duplicated ValueError messages in Quantizer and ModelInspector with the shared InvalidExecutionModeError.
…_raises Match the new exception type instead of the old ValueError message.
guru-desh
commented
Jul 14, 2026
guru-desh
marked this pull request as ready for review
July 14, 2026 20:05
guru-desh
force-pushed
the
add-invalid-execution-error
branch
from
July 14, 2026 23:08
c56af19 to
9b51292
Compare
crowbat
approved these changes
Jul 17, 2026
crowbat
left a comment
crowbat
left a comment
Contributor
There was a problem hiding this comment.
InvalidExecutionModeError changes themselves seem fine to me, approving
dengqiaoyu
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are repeated ValueErrors with similar messaging for raising exceptions for invalid execution modes (if neither graph nor eager is specified). This PR consolidates it into a custom exception so we don't repeat ourselves