Enforce that abstract members are implemented#1690
Draft
bioball wants to merge 1 commit into
Draft
Conversation
This adds a check that abstract members must be implemented. If any members lack an implementation, an error is thrown describing the missing members. Also: we have a bug in `pkl:base`; class `Set` does not implement all members of class `Collection`.
HT154
force-pushed
the
abstract-member-implementation-check
branch
from
July 20, 2026 17:28
a6b0269 to
e7023df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a check that abstract members must be implemented.
If any members lack an implementation, an error is thrown describing
the missing members.
Some open questions here:
overridemodifier when overriding?foo = 1should not be a valid implementation ofabstract foo: Int.Closes #1262