[FIX] Add several fixes from internal team requests.#1
Open
tjoneslo wants to merge 4 commits into
Open
Conversation
- Move the servicetalk providers into their own files for external use. - Fix service_talk_proto_library using (unmodifiable) depsets and replace then with lists. - set the servicetalk deps as neverlink = True to avoid polution of the user's maven deps.
mkosiba
reviewed
May 18, 2026
|
|
||
| compile_time_deps = depset([], transitive = [pi.transitive_jars for pi in all_proto_info]) | ||
| compile_time_infos = depset([], transitive = [pi.transitive_java_infos for pi in all_proto_info]) | ||
| compile_time_infos = [info for pi in all_proto_info for info in pi.transitive_java_infos] |
There was a problem hiding this comment.
will this not result in O(n^2) cpu and memory usage that using depset allows us to avoid?
| fields = { | ||
| "jar": "Path to the generated jar", | ||
| "transitive_jars": "depset of all jars required so far", | ||
| "transitive_java_infos": "depset of all JavaInfos, suitable for use with java_common.compile", |
…y one problem with the JavaInfo being a mutable object now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason for the conversion of the
transitive_java_infosto a list, rather than adepset()is in support for Bazel 8. In Bazel 8, therules_javaand theJavaInfoare booted from the internal bazel to the externalrules_java. And in there theJavaInfois now a struct and no longer marked as immutable. And can't be included in adepset. And the rest of the change in thelibrary.bzlis fallout from that one change.