Skip to content

[FIX] Service talk rules use ctx.resolve_tools() which is no longer supported#2

Open
tjoneslo wants to merge 1 commit into
mainfrom
remove-resolve_tools
Open

[FIX] Service talk rules use ctx.resolve_tools() which is no longer supported#2
tjoneslo wants to merge 1 commit into
mainfrom
remove-resolve_tools

Conversation

@tjoneslo
Copy link
Copy Markdown

This has been deprecated in bazel 7, and removed in Bazel 8. It's not needed so remove it.

…upported

This has been deprecated in bazel 7, and removed in Bazel 8. It's not needed so remove it.
Copy link
Copy Markdown

@mkosiba mkosiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see st_toolchain.plugin is in tools so I think this should work. Do we know why we attempted to resolve the plugin early in the past?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants