Skip to content

Fix availability macro definition for AsyncAlgorithms 1.3#406

Open
azarovalex wants to merge 1 commit into
apple:mainfrom
azarovalex:patch-2
Open

Fix availability macro definition for AsyncAlgorithms 1.3#406
azarovalex wants to merge 1 commit into
apple:mainfrom
azarovalex:patch-2

Conversation

@azarovalex
Copy link
Copy Markdown

@azarovalex azarovalex commented Mar 12, 2026

In Package.swift AsyncAlgorithms_v1_3 defines the availability domain as AsyncAlgorithms 1.2 instead of AsyncAlgorithms 1.3.

Comment thread Package.swift
@@ -14,7 +14,7 @@ let AsyncAlgorithms_v1_3 =
#else
Copy link
Copy Markdown
Author

@azarovalex azarovalex Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phausler looking at this more it seems that the whole #else branch is dead code since // swift-tools-version: 6.2 is defined for this manifest? It feels like we can remove #if compiler(>=6.0) && swift(>=6.0) check unless I'm missing something

@phausler
Copy link
Copy Markdown
Member

@swift-ci please test

@azarovalex
Copy link
Copy Markdown
Author

azarovalex commented Apr 15, 2026

@phausler thanks for triggering CI, it seems like it is broken for quite some time tho and failures are not related to thisPR.
I published a new PR that should hopefully fix macOS CI: #409
Linux pipeline seems to have a compiler crash so likely not something we could fix in this repo

@phausler
Copy link
Copy Markdown
Member

That linux crash is really gnarly! Have you made a ticket already on the swift repo GH issues? 'cause that is definitely a huge regression

@azarovalex
Copy link
Copy Markdown
Author

@phausler
Okay I found a two line repro for the crash and opened a new issue in the swift repo: swiftlang/swift#88530

I see the crash happens on macOS too in the separate PR where I try to fix macOS CI, I added a one line workaround there: #409, we'd need to land that PR first to unblock this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants