Adds a new AsyncReader.collect method#415
Merged
Merged
Conversation
Catfish-Man
approved these changes
May 12, 2026
| /// with caution on large datasets. The `limit` parameter serves as a safety mechanism | ||
| /// to prevent excessive memory usage. | ||
| public mutating func collect<Result, Failure: Error>( | ||
| upTo limit: Int, |
Member
There was a problem hiding this comment.
I could see an argument that this might want a default parameter, but I don't think that's critical to decide now
Member
Author
There was a problem hiding this comment.
We had a lot of arguments in the HTTP APIs around this. Our main argument against a default parameter is that it is impossible to pick the default. The only default to pick is Int.max but that makes this vulnerable to remote denial of service attacks if the attack can tricker an essentially unbounded memory collection
Often developers want to collect elements from a reader up to a certain limit. This PR provides a few convenience methods for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Often developers want to collect elements from a reader up to a certain limit. This PR provides a few convenience methods for this.