Fix Korean locale wiring and translation issues#113
Open
sampple-korea wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds improved Korean localization and enables Android locale configuration, alongside expanding parser dictionary support for Korean.
Changes:
- Updated multiple Korean UI strings for clarity/consistency in
AppStrings. - Added Android
locale-configresource and wired it in the manifest. - Added Korean parser dictionary override support and corrected Korean liveupdate dictionary language keys.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/l10n/app_strings.dart | Refines Korean translations across multiple UI strings. |
| android/app/src/main/res/xml/locales_config.xml | Declares supported locales for Android per-app language/locales config. |
| android/app/src/main/AndroidManifest.xml | Registers android:localeConfig to use the new locales config resource. |
| android/app/src/main/kotlin/com/appsfolder/livebridge/liveupdate/ConverterPrefs.kt | Adds Korean parser dictionary override key + includes ko in supported/default language ID sets. |
| android/app/src/main/assets/liveupdate_dictionary_ko.json | Fixes mislabeled language key from en to ko for status label mappings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chavezanalaura061-wq
approved these changes
Jun 14, 2026
chavezanalaura061-wq
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem / motivation
Korean support exists in the Flutter UI table, but Android system app-language metadata was missing.
Korean parser dictionaries were also registered in the Dart/Kotlin loading paths but filtered out by persisted dictionary language preferences.
Some Korean UI strings had placeholder loss, typos, or wording that changed the intended meaning.
Scope of changes
android:localeConfigandres/xml/locales_config.xml.koto supported/default parser dictionary language preferences.parser_dictionary_ko_overridehandling.status_labelslocale keys fromentoko.Testing
git diff --check.Risk / compatibility
Low. Changes are limited to Korean localization wiring and Korean translation data.