Skip to content

fix(deps): pin springdoc-openapi to 2.8.9 for Spring Boot 3.5 compatibility#41977

Open
wyattwalter wants to merge 1 commit into
releasefrom
fm/springdoc-compat-s1
Open

fix(deps): pin springdoc-openapi to 2.8.9 for Spring Boot 3.5 compatibility#41977
wyattwalter wants to merge 1 commit into
releasefrom
fm/springdoc-compat-s1

Conversation

@wyattwalter

@wyattwalter wyattwalter commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What

Pins springdoc-openapi-starter-webflux-ui from 2.6.0 to 2.8.9 in app/server/appsmith-server/pom.xml.

Why

With springdoc enabled, GET /v3/docs returned HTTP 500:

java.lang.NoSuchMethodError: org.springframework.web.method.ControllerAdviceBean.<init>(java.lang.Object)
    at org.springdoc.core.service.GenericResponseService...

The server runs Spring Boot 3.5.14 (Spring Framework 6.2), which removed the ControllerAdviceBean(Object) constructor. springdoc 2.6.0 still calls it, so the OpenAPI docs endpoint fails at runtime. Version 2.8.9 is compatible with Spring Framework 6.2 and generates the spec successfully.

Scope

This only makes the OpenAPI docs endpoint functional when enabled. It does not change any defaults:

  • Docs stay off by default (springdoc.api-docs.enabled=false, springdoc.swagger-ui.enabled=false unchanged).
  • Docs stay authentication-gated — no SecurityConfig / permitAll changes.

The diff is a single dependency-version bump.

Verification

  • mvn -pl appsmith-server dependency:tree -Dincludes=org.springdoc resolves 2.8.9.
  • mvn -pl appsmith-server -am -DskipTests compile → BUILD SUCCESS.
  • Transitive tree is clean (pulls swagger-core-jakarta:2.2.30, swagger-ui:5.21.0 — the expected companions for 2.8.9).

Summary by CodeRabbit

  • Chores
    • Updated the OpenAPI documentation component to a newer version, improving compatibility and access to the latest fixes.

…bility

springdoc-openapi-starter-webflux-ui 2.6.0 calls the
ControllerAdviceBean(Object) constructor, which Spring Framework 6.2
(bundled with Spring Boot 3.5.14) removed. With springdoc enabled this
made GET /v3/docs return HTTP 500 with a NoSuchMethodError. Version
2.8.9 is compatible with Spring Framework 6.2 and generates the spec.

Docs remain disabled by default; this only makes the toggle functional.

Co-Authored-By: Claude <noreply@anthropic.com>
@wyattwalter
wyattwalter requested a review from sharat87 as a code owner July 9, 2026 22:35
@wyattwalter

Copy link
Copy Markdown
Contributor Author

/build-deploy-preview

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/29054992815.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 41977.
recreate: .
base-image-tag: .

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3f1d3f3f-693a-47ea-8ccd-89ace1a65b7b

📥 Commits

Reviewing files that changed from the base of the PR and between ea8e041 and 138b046.

📒 Files selected for processing (1)
  • app/server/appsmith-server/pom.xml

Walkthrough

The server Maven configuration updates springdoc-openapi-starter-webflux-ui from version 2.6.0 to 2.8.9.

Changes

Springdoc dependency update

Layer / File(s) Summary
Update Springdoc version
app/server/appsmith-server/pom.xml
The Springdoc WebFlux UI dependency version is updated from 2.6.0 to 2.8.9.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A version takes flight,
Springdoc blooms in brighter light,
Maven nods in tune,
WebFlux hums a newer rune,
One small change, done right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the dependency bump and the Spring Boot 3.5 compatibility fix.
Description check ✅ Passed The description includes what, why, scope, and verification, though it omits the template's issue, automation, and communication sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fm/springdoc-compat-s1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Deploy-Preview-URL: https://ce-41977.dp.appsmith.com

@github-actions

Copy link
Copy Markdown

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions Bot added the Stale label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant