fix(deps): pin springdoc-openapi to 2.8.9 for Spring Boot 3.5 compatibility#41977
fix(deps): pin springdoc-openapi to 2.8.9 for Spring Boot 3.5 compatibility#41977wyattwalter wants to merge 1 commit into
Conversation
…bility springdoc-openapi-starter-webflux-ui 2.6.0 calls the ControllerAdviceBean(Object) constructor, which Spring Framework 6.2 (bundled with Spring Boot 3.5.14) removed. With springdoc enabled this made GET /v3/docs return HTTP 500 with a NoSuchMethodError. Version 2.8.9 is compatible with Spring Framework 6.2 and generates the spec. Docs remain disabled by default; this only makes the toggle functional. Co-Authored-By: Claude <noreply@anthropic.com>
|
/build-deploy-preview |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/29054992815. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe server Maven configuration updates ChangesSpringdoc dependency update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Deploy-Preview-URL: https://ce-41977.dp.appsmith.com |
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
What
Pins
springdoc-openapi-starter-webflux-uifrom2.6.0to2.8.9inapp/server/appsmith-server/pom.xml.Why
With springdoc enabled,
GET /v3/docsreturned HTTP 500:The server runs Spring Boot 3.5.14 (Spring Framework 6.2), which removed the
ControllerAdviceBean(Object)constructor. springdoc2.6.0still calls it, so the OpenAPI docs endpoint fails at runtime. Version2.8.9is compatible with Spring Framework 6.2 and generates the spec successfully.Scope
This only makes the OpenAPI docs endpoint functional when enabled. It does not change any defaults:
springdoc.api-docs.enabled=false,springdoc.swagger-ui.enabled=falseunchanged).SecurityConfig/permitAllchanges.The diff is a single dependency-version bump.
Verification
mvn -pl appsmith-server dependency:tree -Dincludes=org.springdocresolves2.8.9.mvn -pl appsmith-server -am -DskipTests compile→ BUILD SUCCESS.swagger-core-jakarta:2.2.30,swagger-ui:5.21.0— the expected companions for 2.8.9).Summary by CodeRabbit